-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[STF] Implement kernel chains in the graph backend without child graphs #3707
Open
caugonnet
wants to merge
7
commits into
NVIDIA:main
Choose a base branch
from
caugonnet:stf_kernel_chain_graph
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ok to test |
/ok to test |
1 similar comment
/ok to test |
/ok to test |
🟩 CI finished in 38m 43s: Pass: 100%/20 | Total: 4h 01m | Avg: 12m 04s | Max: 15m 21s | Hits: 68%/10080
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 20)
# | Runner |
---|---|
12 | linux-amd64-cpu16 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
2 | linux-amd64-gpu-rtx2080-latest-1 |
/ok to test |
🟩 CI finished in 31m 35s: Pass: 100%/20 | Total: 3h 27m | Avg: 10m 23s | Max: 16m 19s | Hits: 78%/10080
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
+/- | CUDA Experimental |
python | |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 20)
# | Runner |
---|---|
12 | linux-amd64-cpu16 |
4 | linux-arm64-cpu16 |
2 | windows-amd64-cpu16 |
2 | linux-amd64-gpu-rtx2080-latest-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of kernel chains currently relies on child graphs, which is not the most efficient way to do this.
Otherwise, we need to create the child graph, fill it, then add the child graph which copies the nodes into the actual graph, and finally destroy the child graph. Instead we now have a vector of nodes, and simply add dependencies on the first and last nodes.
Description
closes
Checklist