-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cuda/__init__.py in cuda-parallel
package
#3750
Conversation
🟩 CI finished in 29m 55s: Pass: 100%/1 | Total: 29m 55s | Avg: 29m 55s | Max: 29m 55s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
CCCL C Parallel Library | |
Catch2Helper |
🏃 Runner counts (total jobs: 1)
# | Runner |
---|---|
1 | linux-amd64-gpu-rtx2080-latest-1 |
Wow, losing Weighing "losing
my feeling is: It's better to revert #3597, to get back @leofang for his opinion. |
@vyasr can correct me but IIRC skbuild-core spent some effort enabling editable install: |
It sounds like you are maybe running into scikit-build/scikit-build-core#807? We use editable installs regularly in RAPIDS with scikit-build-core, but there are definitely still some issues. In particular, my guess (just from reading the comments above, I haven't looked at any code) is that the problem is a combination of two things: 1) cuda_cccl is implemented without using the right |
@leofang Unfortunately, that command from the SKBC docs didn't quite work for me. I think we are running into scikit-build/scikit-build-core#807 as @vyasr said.
@vyasr Just to clarify, we are using
@rwgk I would not be opposed to this. I totally agree that editable installs are a huge productivity boost. @oleksandr-pavlyk would you have any objections to reverting #3597? |
Ok, I'm ok with reverting it. I will revisit these changes to make editable install work as intended |
Before we revert: What potential alternatives do people have in mind? It seems like we are saying skbuild-core and editable install are two mutually exclusive choices, until 807 is fixed for which we don't have an ETA. Am I missing something? |
My understanding was:
|
As far as I'm aware, scikit-build does not suffer from this problem, so we can use that until scikit-build-core can be properly adopted |
The original scikit-build package indeed avoids this problem, but it does have different problems with editable installs. If you find those issues easier to deal with then switching back to that could make sense. |
cuda-parallel
package
I'm going to go ahead and merge this PR. We should follow up with a PR that either reverts #3597 or replaces |
* Remove cuda/__init__.py and update README * cuda_parallel editable installs are also broken --------- Co-authored-by: Ashwin Srinath <[email protected]>
Description
This PR removes
cuda/__init__.py
within thecuda_parallel
project. Without this, attempting to import other packages within thecuda
namespace package will fail, e.g.,cuda.core
orcuda.cccl
.Secondly, it updates the install instructions to clarify that we cannot install
cuda_cccl
in editable mode. This is becausescikit-build-core
does not correctly handle editable installs. In particular, it places the CCCL headers insite-packages
, rather than to the project directory, even in editable mode. Thus, the headers will no longer be found incuda_cccl.get_include_paths()
.For similar reasons,
-e
cannot be used forcuda_parallel
either.Checklist