-
Notifications
You must be signed in to change notification settings - Fork 176
Add cufile bindings #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add cufile bindings #684
Conversation
/ok to test 01990c0 |
@sourabgupta3 there are some CI works I'll need to address later, but please proceed to test it locally. It builds on Linux now. |
/ok to test 5fed951 |
/ok to test 70837af |
/ok to test 571f60b |
/ok to test 77dbde4 |
/ok to test a3d62f2 |
/ok to test 5ff2f4e |
/ok to test fac4100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some quick comments. I haven't gone through the whole test suite yet.
/ok to test fbb4cdb |
The CI was not run because the commit cannot be hyperlinked. Must be a raw text. (GitHub does render commit texts to be clickable, so it's hard by eye-balling it, but it does make a difference to the copy-pr-bot...) |
/ok to test dae5893 |
/ok to test f469124 |
/ok to test eaa8d6b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is all green!
@@ -103,6 +104,7 @@ | |||
"numpy": ("https://numpy.org/doc/stable/", None), | |||
"nvvm": ("https://docs.nvidia.com/cuda/libnvvm-api/", None), | |||
"nvjitlink": ("https://docs.nvidia.com/cuda/nvjitlink/", None), | |||
"cufile": ("https://docs.nvidia.com/gpudirect-storage/api-reference-guide/", None), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, this currently does not work, but it's not a blocker for merging.
return version | ||
|
||
|
||
cpdef get_parameter_size_t(int param, intptr_t value): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking about this more, we probably could generate a more user friendly signature?
cpdef get_parameter_size_t(int param, intptr_t value): | |
cpdef size_t get_parameter_size_t(int param): |
which would return a Python int. WDYT? (Same for the other two getter APIs.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.
Description
closes #585
Checklist