Add PTX helpers #686
Draft
Add PTX helpers #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofang
added
P0
kkraus14
reviewed
Jun 6, 2025
| } | ||
|
|
||
|
|
||
| def get_minimal_required_driver_ver_from_ptx_ver(ptx_version: str) -> int: |
There was a problem hiding this comment.
Instead of driver_ver should we call this cuda_ver? Since someone could be using nvjitlink instead?
Comment on lines
+89
to
+90
| # Regex pattern to match .version directive and capture the version number | ||
| _ptx_ver_pattern = re.compile(r'\.version\s+([0-9]+\.[0-9]+)') |
There was a problem hiding this comment.
Maybe a future note that this will slow down import time which some people care about and that we could potentially lazily initialize this instead if needed?
| >>> get_ptx_ver(ptx) | ||
| '8.8' | ||
| """ | ||
| m = _ptx_ver_pattern.search(ptx) |
There was a problem hiding this comment.
Based on https://docs.nvidia.com/cuda/parallel-thread-execution/#source-format, the first line is always going to be .version, so we'd probably be better off avoiding the regular expression and always just look at the beginning of the string?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #653.
Checklist