-
Notifications
You must be signed in to change notification settings - Fork 171
Make a few memory management objects public + Miscellaneous doc updates #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leofang
wants to merge
5
commits into
NVIDIA:main
Choose a base branch
from
leofang:default_mr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Resource public APIs
/ok to test a6387a0 |
|
/ok to test cc0f6ce |
…g of stream=None; more docs
/ok to test 58323ac |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #596.
Buffer
andMemoryResource
are already public (ex: returned byDevice.memory_resource.allocate()
). We just expose them under thecuda.core
namespace for documentation purposes (Doc: Documentcuda.core
public (but non-entry-point) objects #601)Buffer
's destructor would use the default stream if stream is not passed explicitly. This isn't right because it takes away the control from the memory resource authors. We now always let the memory resource make the call.Buffer
has an__init__()
. This isn't right (since we want buffers to be returned byMR.allocate()
) if we want to make it public. I moved this support tofrom_handle()
.DeviceMemoryResource
andLegacyPinnedMemoryResource
are named after their respective cccl-rt/cudax counterparts.__cuda_stream__
protocol has a protocol type now (IsStreamT
)__cuda_stream__
Checklist