Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing NVQC integration tests #2300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix failing NVQC integration tests #2300

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ada2d1
Fix failing NVQC integration tests
annagrin Oct 18, 2024
fe97f93
Merge branch 'main' into fix-nvqc-integration-tests
sacpis Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/validate_container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ do
# Skipped long-running tests (variational optimization loops) for the "remote-mqpu" target to keep CI runtime managable.
# A simplified test for these use cases is included in the 'test/Remote-Sim/' test suite.
# Skipped tests that require passing kernel callables to entry-point kernels for the "remote-mqpu" target.
if [[ "$ex" == *"vqe_h2"* || "$ex" == *"qaoa_maxcut"* || "$ex" == *"gradients"* || "$ex" == *"grover"* || "$ex" == *"multi_controlled_operations"* || "$ex" == *"phase_estimation"* || "$ex" == *"trotter_kernel_mode"* || "$ex" == *"builder.cpp"* ]];
if [[ "$ex" == *"vqe_h2"* || "$ex" == *"qaoa_maxcut"* || "$ex" == *"gradients"* || "$ex" == *"grover"* || "$ex" == *"multi_controlled_operations"* || "$ex" == *"phase_estimation"* || "$ex" == *"building_kernels"* || "$ex" == *"trotter_kernel_mode"* || "$ex" == *"builder.cpp"* ]];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I meant to put the comment here: Could you please add a link to #2299 in this file itself to explain that is the reason for this test being disabled? (We should probably do that for the others too, but those can probably wait.)

Copy link
Collaborator

@bmhowe23 bmhowe23 Oct 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, I think these changes should be reverted because I think the required changes would be near here instead:

cuda-quantum/.github/workflows/integration_tests.yml

Line 670 in 94f6ee5

# Test NVQC Python examples + Python MLIR execution tests (not IR tests)
.

And here:

cuda-quantum/.github/workflows/integration_tests.yml

Line 789 in 94f6ee5

for ex in `find examples/python python/tests/mlir/target -name '*.py'`; do

then
let "skipped+=1"
echo "Skipping $t target.";
Expand Down
Loading