Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support measurements of subveqs for braket #2416

Merged
merged 56 commits into from
Nov 27, 2024
Merged

Support measurements of subveqs for braket #2416

merged 56 commits into from
Nov 27, 2024

Conversation

annagrin
Copy link
Collaborator

@annagrin annagrin commented Nov 25, 2024 •
edited
Loading

Description

Support measurements of subveqs for braket

  • Add support for setting and using output names in braket executor and server helper
  • Add CombineMeasurements pass
    • extend measurements from subveq to the full vector and add output_names attributes
    • combine separate measurements into one
  • Remove passes in translateToOpenQasm pipeline that would be normally specified in target config files.
  • Add tests

annagrin and others added 30 commits November 14, 2024 18:25
@annagrin
Add missing passes for translation to OpenQasm2
e436e95 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into br…
4d7e74c 
…aket-pipeline

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Fix failing tests
6744327 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into br…
2c9e355 
…aket-pipeline

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Fix failing tests and format
fec4e34 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Address CR comments
fc81076 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Address CR comments
8918c92 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Fix failing tests
774d337 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Fix failing tests
c1b4730 
Signed-off-by: Anna Gringauze <[email protected]>
@khalatepradnya
* Added Python tests for the 'braket' target
ec4edf7 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Skip expand measurements pass
6c28a93 
* Two more tests working

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Ignore classical operations in OpenQASM2.0 translation
c68ba3e 
* Additional tests

Co-authored-by: Eric Schweitz <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Support U3 gate
43a6cda 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Test for other simulators
cfe5c12 
* Test for asynchronous sampling API
* Failing test for observe API
* More tests to cover all native gates, custom operations
* One more test - check kernel that takes arguments

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Remove the combine-quantum-alloc pass since multiple registers are
ed228bf 
  not supported.
* Simplify test setup since mock server isn't being used.

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Clean-up test, use 'Amazon Braket' in messages
35138a0 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
Merge branch 'main' into braket-fixes
345960e
@khalatepradnya
* Decomposition patterns for R1, CRz, Sdg
bcf9054 
Co-authored-by: Bettina Heim <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
@annagrin
Remove and add some passes to braket
2047b2b 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge with main
96cfecb 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge with braket-fixes
50c0658 
Signed-off-by: Anna Gringauze <[email protected]>
@khalatepradnya
* Added Python tests for the 'braket' target
48a3de3 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Skip expand measurements pass
7634817 
* Two more tests working

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Ignore classical operations in OpenQASM2.0 translation
6b2469f 
* Additional tests

Co-authored-by: Eric Schweitz <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Support U3 gate
45205be 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Test for other simulators
2315af9 
* Test for asynchronous sampling API
* Failing test for observe API
* More tests to cover all native gates, custom operations
* One more test - check kernel that takes arguments

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Remove the combine-quantum-alloc pass since multiple registers are
b79042e 
  not supported.
* Simplify test setup since mock server isn't being used.

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Clean-up test, use 'Amazon Braket' in messages
1e653fe 
Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Decomposition patterns for R1, CRz, Sdg
fbad12a 
Co-authored-by: Bettina Heim <[email protected]>

Signed-off-by: Pradnya Khalate <[email protected]>
@khalatepradnya
* Addd tdg decomposition
aef659e 
Signed-off-by: Pradnya Khalate <[email protected]>
@annagrin
Address CR comments
b7c6ef5 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Format
ae14c37 
Signed-off-by: Anna Gringauze <[email protected]>
@annagrin annagrin mentioned this pull request Nov 27, 2024
Open
4 tasks
@annagrin
Address CR comments
3966ee3
@annagrin
DCO Remediation Commit for Anna Gringauze <[email protected]>
797ea89 
I, Anna Gringauze <[email protected]>, hereby add my Signed-off-by to this commit: 3966ee3

Signed-off-by: Anna Gringauze <[email protected]>
@annagrin
Merge branch 'main' of https://github.com/NVIDIA/cuda-quantum into br…
e92e5f1 
…aket-pipeline-3

Signed-off-by: Anna Gringauze <[email protected]>
bmhowe23
bmhowe23 approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming the CI passes, these changes LGTM (modulo any new issues we need to open to track future work). Thanks for your quick work on this, @annagrin!

@annagrin annagrin enabled auto-merge (squash) November 27, 2024 01:38
@annagrin annagrin merged commit 1dea79e into NVIDIA:main Nov 27, 2024
210 of 211 checks passed
@annagrin annagrin mentioned this pull request Nov 27, 2024
Merged
@khalatepradnya khalatepradnya changed the title Support measurements of subveqs for bracket Support measurements of subveqs for braket Dec 2, 2024
@khalatepradnya khalatepradnya mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalatepradnya khalatepradnya khalatepradnya left review comments

@schweitzpgi schweitzpgi schweitzpgi left review comments

@boschmitt boschmitt boschmitt left review comments

@bmhowe23 bmhowe23 bmhowe23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annagrin @boschmitt @schweitzpgi @bmhowe23 @khalatepradnya