Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nvq++] Removes MLIR's memref dialect. #2438

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[nvq++] Removes MLIR's memref dialect. #2438

wants to merge 3 commits into from

Commits on Nov 28, 2024

  1. [nvq++] Removes MLIR's scf dialect 

    We don't use this dialect and its presence is a historical artifact.
This change triggered the removal of two tests:

* `test/Quake/ghz.qke`
* `test/Quake/iqft.qke`

Both tests are a reminder of a past when we had to write quantum kernels
directly in MLIR because of a lack of frontend. Both no longer test
aything useful.

The commit modifies `test/Quake/canonical-2.qke`, which was only testing
the canonicalization of `cc.scope` operations. The new form is removes
the clutter, making the test more precise.

`test/Translate/ghz.qke` had to be modified because it uses MLIR's
`affined.for` and its conversion to LLVMDialect requires `scf.for`.

Signed-off-by: boschmitt <[email protected]>
    @boschmitt
    boschmitt committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    3500632 View commit details
    Browse the repository at this point in the history

  2. [nvq++] Remove MLIR's affine dialect. 

    We don't use this dialect. The removal triggered the removel of one
test:

* `test/Quake/ccnot.qke`

The test was not testing anything useful, only kernel inlining, which is
already covered in other tests. Furthermore, the test is misleading
because, contrary to what the kernel name might indicate, it is not
implementing a `ccnot`.

Signed-off-by: boschmitt <[email protected]>
    @boschmitt
    boschmitt committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    982278e View commit details
    Browse the repository at this point in the history

  3. [nvq++] Removes MLIR's memref dialect. 

    We don't use this dialect. Most changes were to substitute `memref` ops
with `cc` ops in tests.

Signed-off-by: boschmitt <[email protected]>
    @boschmitt
    boschmitt committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    6ab9094 View commit details
    Browse the repository at this point in the history