Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable serialized python code execution #2607

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sacpis
Copy link
Collaborator

@sacpis sacpis commented Feb 11, 2025

Enable serialized python code execution (optimizer.optimize) for the paid-tier.

Tested it locally using remote-mqpu target.

Tests include

  1. One level kernel
  2. Nested kernels
  3. With/without positional arguments to the optimizer.optimize function
  4. Programs without optimizer.optimize calls

@bmhowe23
Copy link
Collaborator

Need to figure out a way to start nvqc_prozy.py script on the server (like we are doing for cudaq-qpud process).

I believe that is automatically handled when you use docker/release/cudaq.nvqc.Dockerfile.

@@ -32,7 +32,7 @@
WATCHDOG_TIMEOUT_SEC = 0
RUN_AS_NOBODY = False # Expect this to be overridden to true for NVQC deployment
SUDO_FOUND = False
CUDAQ_SER_CODE_EXEC = False
CUDAQ_SER_CODE_EXEC = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make this the default? It is currently "opt in", where you must set an environment variable in the deployment in order to activate this (see line 270). If we make this change, then it will become "opt out".

Copy link
Collaborator Author

@sacpis sacpis Feb 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we are planning to make it the default. @bettinaheim can confirm that. As there will be only one paid tier going forward.

So that even if we set the env variable to any value (True or False) it will take that value. If we don't, then the default will be True. So the env variable (if set) in the deployment will always takes precedence.

@sacpis sacpis requested a review from bettinaheim February 11, 2025 02:14
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 11, 2025
@sacpis sacpis marked this pull request as ready for review February 11, 2025 17:28
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants