-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Bump up CUDA version to 12.8 in build #2657
Conversation
@@ -33,7 +33,7 @@ esac | |||
|
|||
CUDA_DOWNLOAD_URL=https://developer.download.nvidia.com/compute/cuda/repos | |||
CUDA_ARCH_FOLDER=$([ "$(uname -m)" == "aarch64" ] && echo sbsa || echo x86_64) | |||
CUDA_VERSION_SUFFIX=$(echo ${CUDART_VERSION:-'12.0'} | tr . -) | |||
CUDA_VERSION_SUFFIX=$(echo ${CUDART_VERSION:-'12.8'} | tr . -) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others can correct me if I'm wrong because I'm definitely not sure about this, but we might want to keep this one at 12.0 to make sure that we can run on 12.0 despite building on 12.8.
pyproject.toml
Outdated
'nvidia-cublas-cu12 ~= 12.8', | ||
'nvidia-cuda-runtime-cu12 ~= 12.8', | ||
'nvidia-cusolver-cu12 ~= 11.7', | ||
'nvidia-cuda-nvrtc-cu12 ~= 12.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to keep these wheel dependencies the same as before so that users who are just using CUDA 12.0 runtime can still use our wheels.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current: 'nvidia-cublas-cu12 ~= 12.0'
Q: Should I make these >=
?
Without this change, I'm getting following error in Publishing -
2025-02-28T04:28:57.5222378Z Collecting nvidia-cublas-cu12~=12.0
2025-02-28T04:28:57.5279353Z Downloading nvidia_cublas_cu12-12.8.3.14-py3-none-manylinux_2_27_x86_64.whl (609.6 MB)
2025-02-28T04:28:59.2682292Z ━━━━━━━━━╸ 163.8/609.6 MB 163.7 MB/s eta 0:00:03
2025-02-28T04:28:59.8344767Z ERROR: THESE PACKAGES DO NOT MATCH THE HASHES FROM THE REQUIREMENTS FILE. If you have updated the package versions, please update the hashes. Otherwise, examine the package contents carefully; someone may have tampered with them.
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
4cee7b9
to
bd919a8
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
* Also use cudart v12.8 whereever applicable Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
Signed-off-by: Pradnya Khalate <[email protected]>
bd919a8
to
43e8fec
Compare
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
cudart
v12.8 wherever applicable