Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add checks to the CC dialect types. #2679

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

schweitzpgi
Copy link
Collaborator

We do not allow CC dialect types to "contain" quantum types.

Fix some issues in the C++ bridge that were resulting in these invalid hybrid types being created.

Description

@schweitzpgi schweitzpgi marked this pull request as draft March 1, 2025 00:29
Copy link

github-actions bot commented Mar 3, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
Copy link

github-actions bot commented Mar 3, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 3, 2025
@schweitzpgi schweitzpgi marked this pull request as ready for review March 3, 2025 22:42
github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link
Collaborator

@annagrin annagrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric!

Copy link

github-actions bot commented Mar 4, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 4, 2025
We do not allow CC dialect types to "contain" quantum types.

Fix some issues in the C++ bridge that were resulting in these
invalid hybrid types being created.

Signed-off-by: Eric Schweitz <[email protected]>
@schweitzpgi schweitzpgi force-pushed the ch-lock.down.cc.types branch from 5d410f5 to 26042f2 Compare March 5, 2025 16:51
Copy link

github-actions bot commented Mar 5, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 5, 2025
github-actions bot pushed a commit that referenced this pull request Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

@khalatepradnya khalatepradnya enabled auto-merge (squash) March 7, 2025 04:10
@khalatepradnya khalatepradnya merged commit 8f31eae into NVIDIA:main Mar 7, 2025
208 of 209 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants