Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Handle more conditions in MidCircuitMeasurementAnalyzer #2701

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

khalatepradnya
Copy link
Collaborator

Ideally this logic should be replaced with quake-add-metadata pass, see issue # 2000.

This PR enhances the checks in the current logic to account for cases when a measurement result is assigned to new value, or is used with boolean operators.

github-actions bot pushed a commit that referenced this pull request Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM ... thanks, @khalatepradnya!

Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened with using the quake metadata pass?

@khalatepradnya
Copy link
Collaborator Author

What happened with using the quake metadata pass?

I am working on it in a branch which isn't ready yet. It also makes one major workflow change in Python which has potential side-effects on capturing values from parent scope. This PR is attempt to mitigate issues for demos next week.

@khalatepradnya khalatepradnya changed the title [Python] Handle more conditions in Python's MidCircuitMeasurementAnalyzer [Python] Handle more conditions in MidCircuitMeasurementAnalyzer Mar 6, 2025
@khalatepradnya khalatepradnya enabled auto-merge (squash) March 6, 2025 17:54
@khalatepradnya khalatepradnya self-assigned this Mar 6, 2025
@khalatepradnya khalatepradnya merged commit 03138c9 into NVIDIA:main Mar 7, 2025
212 of 213 checks passed
@khalatepradnya khalatepradnya deleted the hot-fix-midcircuitmeas branch March 7, 2025 01:04
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants