Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rydberg Hamiltonian in C++ Evolve API #2704

Merged
merged 8 commits into from
Mar 8, 2025
Merged

Support Rydberg Hamiltonian in C++ Evolve API #2704

merged 8 commits into from
Mar 8, 2025

Conversation

nvidia-dobri
Copy link
Collaborator

This enables Rydberg Hamiltonian evolution through analog quantum backends, currently QuEra and Pasqal. Authentication unique to each platform is required to run the examples.

QuEra requires valid AWS credentials with Braket access:

nvq++ --target quera 'quera_basic.cpp' -o out.x && CUDAQ_LOG_LEVEL=info ./out.x
nvq++ --target quera 'quera_intro.cpp' -o out.x && CUDAQ_LOG_LEVEL=info ./out.x

Pasqal requires env variables:

  • PASQAL_PROJECT_ID from Pasqal Cloud
  • PASQAL_AUTH_TOKEN obtained with pasqal_cloud python library.
nvq++ --target pasqal 'pasqal.cpp' -o out.x && CUDAQ_LOG_LEVEL=info ./out.x

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Mar 6, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Mar 6, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

schweitzpgi
schweitzpgi reviewed Mar 6, 2025
View reviewed changes
Copy link
Collaborator

@schweitzpgi schweitzpgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dobri. LGTM with a quick skim. Just a couple of nits.

@khalatepradnya
Copy link
Collaborator

We need a follow-up docs update PR to add the new examples for Pasqal and QuEra.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 6, 2025
@cuda-quantum-bot
Docs preview for PR #2704.
e731ebc
@khalatepradnya
Copy link
Collaborator

Manually tested examples for both Pasqal and QuEra.
(QuEra system was unavailable at the time of testing so checked payload and canceled job.)
Also tried Pasqal with nvq++ --target pasqal --pasqal-machine EMU_FREE source.cpp

@nvidia-dobri
code review
82283d8 
Signed-off-by: Dobri Y <[email protected]>
khalatepradnya
khalatepradnya approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@khalatepradnya khalatepradnya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @nvidia-dobri .

@sacpis
Copy link
Collaborator

sacpis commented Mar 7, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
@cuda-quantum-bot
Docs preview for PR #2704.
2b66caf
@nvidia-dobri
use EXPECT_ANY_THROW
0f7a846 
Signed-off-by: Dobri Y <[email protected]>
@nvidia-dobri
Copy link
Collaborator Author

nvidia-dobri commented Mar 7, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

1 similar comment
@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Mar 7, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
@cuda-quantum-bot
Docs preview for PR #2704.
e52e304
@nvidia-dobri nvidia-dobri enabled auto-merge (squash) March 7, 2025 20:00
@sacpis sacpis self-requested a review March 7, 2025 20:03
bmhowe23
bmhowe23 approved these changes Mar 7, 2025
View reviewed changes
Copy link
Collaborator

@bmhowe23 bmhowe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the changes in the .github directory ... they LGTM.

@nvidia-dobri
Copy link
Collaborator Author

nvidia-dobri commented Mar 7, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@nvidia-dobri nvidia-dobri disabled auto-merge March 7, 2025 22:05
@nvidia-dobri
Fix pasqal c++ test
55a01d2 
Signed-off-by: Dobri Y <[email protected]>
@nvidia-dobri
Copy link
Collaborator Author

nvidia-dobri commented Mar 7, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@nvidia-dobri
Copy link
Collaborator Author

nvidia-dobri commented Mar 7, 2025 •
edited by github-actions bot
Loading

/ok to test

Command Bot: Processing...

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
@cuda-quantum-bot
Docs preview for PR #2704.
64d0841
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 8, 2025

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Mar 8, 2025
@cuda-quantum-bot
Docs preview for PR #2704.
bd71908
@nvidia-dobri nvidia-dobri merged commit b05087c into NVIDIA:main Mar 8, 2025
213 checks passed
@nvidia-dobri nvidia-dobri deleted the evolve_rydberg branch March 8, 2025 01:18
github-actions bot pushed a commit that referenced this pull request Mar 8, 2025
@cuda-quantum-bot
Cleaning up docs preview for PR #2704.
369bc0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schweitzpgi schweitzpgi schweitzpgi left review comments

@khalatepradnya khalatepradnya khalatepradnya approved these changes

@sacpis sacpis sacpis approved these changes

@bmhowe23 bmhowe23 bmhowe23 approved these changes

@bettinaheim bettinaheim Awaiting requested review from bettinaheim

@1tnguyen 1tnguyen Awaiting requested review from 1tnguyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nvidia-dobri @khalatepradnya @sacpis @schweitzpgi @bmhowe23