PR #2683 Follow up #2705
PR #2683 Follow up #2705
Conversation
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Co-authored-by: Bettina Heim <[email protected]> Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
… perform copy elision Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
…ctor<double> Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
…o gcc dependencies Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Sachin Pisal <[email protected]>
Signed-off-by: Sachin Pisal <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
| @@ -24,20 +24,19 @@ class evolve_result { | |||
| // The final state after the time evolution. | |||
| state final_state; | |||
|
|
|||
| public: | |||
There was a problem hiding this comment.
Can we match the spec here? Basically remove the intermediate / final distinction for state and expectation values and initialize everything to std::nullopt.
https://gitlab-master.nvidia.com/cuda-quantum/cudaq-spec/-/merge_requests/20/diffs
There was a problem hiding this comment.
Just a QQ. Does this mean cleaning up Python version as well?
https://github.com/NVIDIA/cuda-quantum/blob/main/python/runtime/common/py_EvolveResult.cpp#L43
There was a problem hiding this comment.
We will have to change the Python dynamics version as well? Seems like right now evolve is kind of dependent on evolve_internal.
Can we make this change in the next release?
There was a problem hiding this comment.
We should be able to keep the Python API as is, juggling the binding methods. If it's more work than that, I agree, we shouldn't do it now.
This changes the public-facing api for evolve, so it's harder to change in next release.
Signed-off-by: Sachin Pisal <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
workflow * Removed scalar_operator from cpp example Signed-off-by: Sachin Pisal <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
PR #2683 Follow up