-
Notifications
You must be signed in to change notification settings - Fork 245
Migrate Python dynamics solver implementation to pybind11 #2853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
…ate copy Signed-off-by: Thien Nguyen <[email protected]>
f85afc2
to
bf694ff
Compare
- Make sure we do accumulate + scaling in a single cublas call - Optimize tempory memory allocation with cuda mempool: we allocate quite a lot of temporary memory during the evolution hence make sure to use mempool (as cupy does) Signed-off-by: Thien Nguyen <[email protected]>
bf694ff
to
4774610
Compare
… MPI-compatible Signed-off-by: Thien Nguyen <[email protected]>
dynamics solver involves many repetitive steps, hence, conventional trace logging is not suitable. Adding a metric map, which tracks the total time across many calls, e.g., to computeAction, to display aggregated data. Refactor the allocator into a helper class for better configurability. Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
Signed-off-by: Thien Nguyen <[email protected]>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Still review in progress.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally finished :) Have put some comments.
Signed-off-by: Thien Nguyen <[email protected]>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Thien Nguyen <[email protected]>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @1tnguyen.
Signed-off-by: Thien Nguyen <[email protected]>
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Description
Migrate dynamics
evolve
to C++Remove operator conversion utility in Python. This is now completely handled in C++ via operator bindings.
Create bindings for time stepper, integrator, and expectation value calculator. Note: these bindings are for internal usage, i.e., not for end users. Python integrators (scipy/torch) are now using the C++ time stepper as well.
Refactor and clean up the
CuDensityMatState
class. Add support for distributed state.