Add ability to create a measurement matrix from a Clifford-only kernel #2919
+687
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
amccaskey
reviewed
May 16, 2025
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
sacpis
reviewed
May 19, 2025
sacpis
reviewed
May 19, 2025
sacpis
reviewed
May 19, 2025
sacpis
reviewed
May 19, 2025
sacpis
reviewed
May 19, 2025
sacpis
reviewed
May 19, 2025
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
bmhowe23
commented
May 20, 2025
runtime/common/ExecutionContext.h
Outdated
| @@ -117,6 +117,13 @@ class ExecutionContext { | |||
| /// order. | |||
| bool explicitMeasurements = false; | |||
|
|
|||
| /// @brief Probability of occurrence of each error mechanism (column) in PCM | |||
There was a problem hiding this comment.
After some offline discussions with @justinlietz, I'm going to rename the "PCM" references to "MSM" (Measurement Syndrome Matrix), per https://arxiv.org/pdf/2407.13826
There was a problem hiding this comment.
Renamed in 8cc4d61
For accuracy in names, use Measurement Syndrome Matrix instead of Parity Check Matrix. Reference: https://arxiv.org/pdf/2407.13826 Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: Ben Howe <[email protected]>
Signed-off-by: Ben Howe <[email protected]>
|
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to create a noise-aware measurement matrix. Each row of the matrix corresponds to a measurement in the kernel, and each column of the matrix corresponds to a particular error (noise) mechanism. Each entry in the matrix tells you whether a particular measurement (row) would flip if a particular error (column) happened. This is implemented using Stim's
stim::FrameSimulatorC++ API to keep track of what would flip and what would not, depending on the circuit.As currently written, this is only supported via our C++ API.
Summary of changes:
cudaq::ExecutionContextstructure."pcm_size"and"pcm") from which the Stim simulator will recognize and process accordingly. (runtime/nvqir/CircuitSimulator.hhad to be updated to recognize these as well.)"pcm_size"needs to be run first to count the number of measurements and error mechanisms in a circuit. The"pcm"version is run right after that to populate the matrix. (See test for details.)Todo:
Add a bit more validation to the tests(done)