Add BF16 dtype mapping for python EVT #1832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! No worries about adding tests. I'll run this through internally and get back about the ability to merge. |
|
This PR has been labeled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1824
I was thinking of adding a test case for this, but currently the dtype is hard-coded to FP16
cutlass/test/python/cutlass/evt/utils/evt_testbed.py
Line 206 in 44dae8b
Would take some refactoring to test multiple dtypes at the same time. Lmk if you want to add any tests, or don't add anything is fine.
@jackkosaian