Update repo to serve as Go library #130
Open
+3
−258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
elezar
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Just a general question: How many of our projects depend on this image already? Have they all been migrated off it again?
elezar
reviewed
Feb 25, 2025
There was a problem hiding this comment.
What was the purpose of this image?
elezar
reviewed
Feb 25, 2025
| @@ -11,4 +11,4 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| GOLANG_VERSION ?= 1.23.5 | |||
| GOLANG_VERSION ?= 1.24.0 | |||
There was a problem hiding this comment.
Question: Could we use hack/golang-version.sh here instead?
There was a problem hiding this comment.
(This would mean that we have a golang Dockerfile in deployments/devel).
There was a problem hiding this comment.
sure, a way to leverage dependabot, do we agree that said image wouldn't require an image action, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.