This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Add a profile for ICC-2022. #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Mar 23, 2023
miscco
approved these changes
Mar 23, 2023
miscco
reviewed
Mar 23, 2023
gevtushenko
reviewed
Mar 23, 2023
Comment on lines
+47
to
+51
| if (${CMAKE_CXX_COMPILER_ID} STREQUAL "IntelLLVM") | ||
| set(LIBCUDACXX_TEST_COMPILER_FLAGS | ||
| "${LIBCUDACXX_TEST_COMPILER_FLAGS} \ | ||
| --compiler-options=-fno-fast-math") | ||
| endif() |
There was a problem hiding this comment.
These options seem to be targeting nvcc (nvc++?) when icpx is the host compiler. Should this code be under if (${CMAKE_CUDA_COMPILER_ID} STREQUAL "NVIDIA")?
There was a problem hiding this comment.
AFAIK this should be applied always because of our libcxx tests where we pretent to be a standard library
There was a problem hiding this comment.
I specifically disabled libcxx tests with this compiler. We can turn them on later, but I wanted our most important coverage to come first.
miscco
force-pushed
the
docker/icc_config
branch
2 times, most recently
from
b496798 to
2472a5f
Compare
This breaks essentially all floating point tests. With this I can run the whole test suite fine with ICC-2023.0.0
miscco
force-pushed
the
docker/icc_config
branch
from
2472a5f to
dc5e51a
Compare
gevtushenko
reviewed
Mar 23, 2023
| @@ -648,8 +648,8 @@ typedef __char32_t char32_t; | |||
| #define _LIBCUDACXX_HAS_VIRTUAL_DESTRUCTOR(...) __has_virtual_destructor(__VA_ARGS__) | |||
| #endif | |||
|
|
|||
| #if __check_builtin(is_literal) | |||
| #define _LIBCUDACXX_IS_LITERAL(...) __is_literal(__VA_ARGS__) | |||
| #if __check_builtin(is_literal_type) | |||
There was a problem hiding this comment.
Regarding __check_builtin -> __has_builtin changes that used to be here. The __has_builtin has different result compared to !__is_identifier for some compilers. Here's a reference.
Co-authored-by: Georgy Evtushenko <[email protected]>
Co-authored-by: Georgy Evtushenko <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new config for ICC to our CI.