Bug entry point #818
Bug entry point #818
Conversation
|
/blossom-ci |
|
/blossom-ci |
| model = model.load() | ||
| else: | ||
| raise ValueError(f"Model {name} is not a valid entry point.") |
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| import warnings | |||
| from importlib.metadata import EntryPoint, entry_points | |||
| from importlib_metadata import EntryPoint as EntryPointOld | |||
There was a problem hiding this comment.
Can we avoid this import from importlib_metadata? This has been deprecated in the newer versions of Python
| @@ -16,6 +16,7 @@ | |||
|
|
|||
| import warnings | |||
| from importlib.metadata import EntryPoint, entry_points | |||
| from importlib_metadata import EntryPoint as EntryPointOld | |||
There was a problem hiding this comment.
Can you add a small comment explaining what this is, why it here?
We will forget in a month.
importlib_metadata is a back port of new APIs for previous python vesions, also users dont necessarily need this installed. If it happens to be installed, we should check it.
Or does this come with base python (I dont think so but maybe)
There was a problem hiding this comment.
Best guess is somehow older versions of importlib are getting being used and some how this impacts the return type on entry_points
There was a problem hiding this comment.
|
/blossom-ci |
#817