Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better username evaluation in get_user_obj #278

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pycognito/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,13 @@ def get_user_obj(
what we'd like to display to the users
:return: dictionary of the Cognito user response
"""
# try to detect the username from self or from the metadata if not set
if username is None:
if metadata is None:
username = self.username
else:
username = self.username or metadata.get("username")

return self.user_class(
username=username,
attribute_list=attribute_list,
Expand Down