-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootloader reset improvements #51
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #51 +/- ##
==========================================
- Coverage 60.71% 60.67% -0.05%
==========================================
Files 14 14
Lines 1642 1653 +11
==========================================
+ Hits 997 1003 +6
- Misses 645 650 +5 ☔ View full report in Codecov by Sentry. |
31408fd
to
98dc8da
Compare
Rebased on changes in dev branch now |
I've made a few changes to CI, as it looks like pre-commit hooks weren't running to check for formatting. You can re-format your code like so: pip install pre-commit
pre-commit install
pre-commit run --all-files |
ok, I have run the pre commit hooks and fixed errors detected. |
Thanks! Can you also revert the changes to |
other probe methods Fixes NabuCasa#52
sure, I have made that change as well. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [universal-silabs-flasher](https://togithub.com/NabuCasa/universal-silabs-flasher) | `==0.0.15` -> `==0.0.16` | [![age](https://developer.mend.io/api/mc/badges/age/pypi/universal-silabs-flasher/0.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/universal-silabs-flasher/0.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/universal-silabs-flasher/0.0.15/0.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/universal-silabs-flasher/0.0.15/0.0.16?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>NabuCasa/universal-silabs-flasher (universal-silabs-flasher)</summary> ### [`v0.0.16`](https://togithub.com/NabuCasa/universal-silabs-flasher/releases/tag/v0.0.16) [Compare Source](https://togithub.com/NabuCasa/universal-silabs-flasher/compare/v0.0.15...v0.0.16) #### What's Changed - Compatibility with gpiod 2.x by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/50](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/50) - Migrate to zigpy CI and pre-commit hooks by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/53](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/53) - Bootloader reset improvements by [@​darkxst](https://togithub.com/darkxst) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/51](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/51) - Disconnect stream writer without closing the transport by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/58](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/58) - EBL parsing by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/11](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/11) - Update README.md with bootloader reset option by [@​darkxst](https://togithub.com/darkxst) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/54](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/54) - Run `isort` to fix CI by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/59](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/59) **Full Changelog**: NabuCasa/universal-silabs-flasher@v0.0.15...v0.0.16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/marinatedconcrete/config). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
I have two more devices to add support for bootloader reset. The first is the Sonoff iHost included in this series, second will be a forthcoming device from Smlight.
The current bootloader reset implementation doesnt really scale cleanly for adding more devices, so I have split it out into a new
--bootloader-reset
option. I made it a global option so it can be shared with bothprobe
andflash
commands. Kept compatibility with the previous individual device flags, in case there is any usage from scripts currently.