Disconnect stream writer without closing the transport #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #58 +/- ##
==========================================
- Coverage 60.67% 60.62% -0.05%
==========================================
Files 14 14
Lines 1653 1656 +3
==========================================
+ Hits 1003 1004 +1
- Misses 650 652 +2 ☔ View full report in Codecov by Sentry. |
robarnold
referenced
this pull request
in marinatedconcrete/config
Jan 4, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [universal-silabs-flasher](https://togithub.com/NabuCasa/universal-silabs-flasher) | `==0.0.15` -> `==0.0.16` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>NabuCasa/universal-silabs-flasher (universal-silabs-flasher)</summary> ### [`v0.0.16`](https://togithub.com/NabuCasa/universal-silabs-flasher/releases/tag/v0.0.16) [Compare Source](https://togithub.com/NabuCasa/universal-silabs-flasher/compare/v0.0.15...v0.0.16) #### What's Changed - Compatibility with gpiod 2.x by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/50](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/50) - Migrate to zigpy CI and pre-commit hooks by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/53](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/53) - Bootloader reset improvements by [@​darkxst](https://togithub.com/darkxst) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/51](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/51) - Disconnect stream writer without closing the transport by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/58](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/58) - EBL parsing by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/11](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/11) - Update README.md with bootloader reset option by [@​darkxst](https://togithub.com/darkxst) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/54](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/54) - Run `isort` to fix CI by [@​puddly](https://togithub.com/puddly) in [https://github.com/NabuCasa/universal-silabs-flasher/pull/59](https://togithub.com/NabuCasa/universal-silabs-flasher/pull/59) **Full Changelog**: NabuCasa/universal-silabs-flasher@v0.0.15...v0.0.16 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/marinatedconcrete/config). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57.
CPython changed the functionality of
StreamWriter.__del__to automatically close the underlying transport when the writer object is deleted: python/cpython#109321.This behavior silently closed the serial port upon completion of the XMODEM transfer on newer CPython patch releases, something that did not happen earlier. I only caught it by swapping in https://github.com/puddly/serialpy with debug logging.
The alternative to this PR (that does not rely on private attribute access) is to keep all
StreamWriterobjects around in a global graveyard list after use.