EmissaryServer shutdown when unannounced places are started in strict-mode #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drivenflywheel
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Verified with local testing and a "registered" coordination place that coordinates the unregistered DelayPlace:
2023-12-13 17:32:16,452 localhost-8001 INFO emissary.server.EmissaryServer - - Server shut down due to invisible place startups on strict-mode: [DelayPlace]
jpdahlke
added
the
integration
dev-mlb
approved these changes
Jan 24, 2024
|
@jpdahlke I believe we are good on this now after last weeks deployment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If EmissaryServer is started up not in strict-mode, it still will just log unannounced places that are started up.
In strict-mode, the starting of unannounced places will result in EmissaryServer being shutdown.
Added a test to EmissaryServerIT for this, as well as updated StartupTest based on changes made to Startup.