Make various non-user-visible code cleanup tweaks #4980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liz-lavenza
force-pushed
the
dev-tweaks-mar-29
branch
from
9a96633 to
b578684
Compare
MistakeNot4892
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes some math issues with
RAND_FI encountered due to order-of-operation issues with macro argument expansion.Adds some overlooked JSON variables to the JSON unit test.
Makes
/decl/emote/visibleabstract and moves its key and default message onto/decl/emote/visible/tail.Cleans up and optimises noisemap code.
Removes code that caused noisemaps to randomly spawn airlocks if a cell was a certain value. No, really. What??
Sets
abstract_typeonglass_extra.Why and what will this PR improve
Fixes some non-user-visible issues, or issues not exposed by existing upstream code. Also optimises stuff.