Fix tests 4.1.3, 4.1.4, 4.2.1, 4.2.2, 4.2.3, 4.2.4 and way to process data in woketo #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folliked
reviewed
Nov 6, 2016
| // return ''; | ||
| // } | ||
| // | ||
| // return $data; |
There was a problem hiding this comment.
no code in comments please
|
|
||
| public function __construct($maxLength, $message = 'The frame is too big to be processed.') |
| @@ -8,6 +8,7 @@ | |||
| * on the root directory of this project | |||
| */ | |||
|
|
|||
| declare(strict_types=1); | |||
There was a problem hiding this comment.
why ? no good for performance ...
There was a problem hiding this comment.
Because sometimes it's really important. (and it is for some parts of woketo)
There was a problem hiding this comment.
I understand but it is in a central class, so it should be interesting a load tests for the impact. But ok
This commit modify the way of processing binary entry frames. Old way: taking binary frame as websocket frame (and bufferize if it was not complete). New way: it take a binary frame as one or many frames composing one or many messages and bufferize if frames are not complete. This new behavior makes autobahn execute new tests that was crashing woketo. The fix is taking 4 bytes for the mask (sometimes it was less because of a wrong usage of the BitManipulation class). Switch to usage of generators
Nek-
force-pushed
the
fix/wstest-4.1.3
branch
from
3d0c334 to
8dc874d
Compare
Nek-
changed the title
Nek-
changed the title
folliked
approved these changes
Nov 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please notice that the new way of processing data is not great in term of maintainability. This is an echo to #23 .
This PR should close #27
Please notice it also fixes some tests in 9.x.