-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop sofi #314
Develop sofi #314
Conversation
SOFI buy/sell
.env.example SOFI
added 2fa processing and holdings command for sofi
I added Gabes addition of 3 more sms tries as well as it being able to handle both auth 2fa codes and sms 2fa codes
im losing it, i think this works good enough
found a bug when trying to sell, not ready yet |
Fixed selling issues
This should be ready. Features automatic 2FA log in, holdings, and buying/selling in live and dry mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good so far, this is just what stood out immediately when I looked through it
fixed the selling and buy loop with the added function of dry mode handling
@ImNotOssy What else are we waiting on here? I think this is ready to be merged as far as I can tell. |
The weird bug my client got i told you about, you should merge and see what other users experience |
That is what I was thinking too, this should work for most people so let's just let user feedback raise new issues. I will clean this up and then flag Nelson to review it for merge |
# Conflicts: # autoRSA.py
@NelsonDane, please take a look over this code. It should be ready for review from us and then merge. |
…Ossy/develop-sofi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NelsonDane I am fine leaving the rest of the formatting changes for the bot. If you have any pressing issues left, please let me know. If not, I believe this is ready for merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me
Added 2fa processing as well as added a proper holdings fetch function