Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop sofi #314

Merged
merged 79 commits into from
Oct 26, 2024
Merged

Develop sofi #314

merged 79 commits into from
Oct 26, 2024

Conversation

ImNotOssy
Copy link
Contributor

@ImNotOssy ImNotOssy commented Aug 15, 2024

Added 2fa processing as well as added a proper holdings fetch function

@ImNotOssy ImNotOssy marked this pull request as draft August 15, 2024 08:01
I added Gabes addition of 3 more sms tries as well as it being able to handle both auth 2fa codes and sms 2fa codes
im losing it, i think this works good enough
@ImNotOssy ImNotOssy marked this pull request as ready for review August 16, 2024 05:40
@ImNotOssy ImNotOssy marked this pull request as draft August 16, 2024 14:16
@ImNotOssy
Copy link
Contributor Author

found a bug when trying to sell, not ready yet

Fixed selling issues
@ImNotOssy ImNotOssy marked this pull request as ready for review August 16, 2024 15:37
@ImNotOssy
Copy link
Contributor Author

This should be ready. Features automatic 2FA log in, holdings, and buying/selling in live and dry mode.
Please let me know if there's any bugs or issues i missed.

@ImNotOssy ImNotOssy marked this pull request as draft August 16, 2024 22:12
@ImNotOssy ImNotOssy marked this pull request as ready for review August 16, 2024 22:12
@ImNotOssy ImNotOssy marked this pull request as draft August 16, 2024 22:14
@ImNotOssy ImNotOssy marked this pull request as ready for review August 16, 2024 23:46
This was referenced Aug 17, 2024
Copy link
Owner

@NelsonDane NelsonDane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far, this is just what stood out immediately when I looked through it

@matthew55
Copy link
Contributor

@ImNotOssy What else are we waiting on here? I think this is ready to be merged as far as I can tell.

@ImNotOssy
Copy link
Contributor Author

@ImNotOssy What else are we waiting on here? I think this is ready to be merged as far as I can tell.

The weird bug my client got i told you about, you should merge and see what other users experience

@matthew55
Copy link
Contributor

@ImNotOssy What else are we waiting on here? I think this is ready to be merged as far as I can tell.

The weird bug my client got i told you about, you should merge and see what other users experience

That is what I was thinking too, this should work for most people so let's just let user feedback raise new issues. I will clean this up and then flag Nelson to review it for merge

@matthew55
Copy link
Contributor

@NelsonDane, please take a look over this code. It should be ready for review from us and then merge.

Copy link
Contributor

@matthew55 matthew55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NelsonDane I am fine leaving the rest of the formatting changes for the bot. If you have any pressing issues left, please let me know. If not, I believe this is ready for merge.

Copy link
Owner

@NelsonDane NelsonDane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@NelsonDane NelsonDane enabled auto-merge October 26, 2024 22:35
@NelsonDane NelsonDane merged commit 6af97fd into NelsonDane:main Oct 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants