Check if challenge is already approved before raising exception (#5445)

Netflix · Nov 8, 2024 · 051e7c5 · 051e7c5
1 parent f878a3e
commit 051e7c5
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/dispatch/plugins/dispatch_core/plugin.py b/src/dispatch/plugins/dispatch_core/plugin.py
@@ -379,6 +379,9 @@ def validate_mfa_token(
             raise ActionMismatchError("Action mismatch")
         if not challenge.valid:
             raise ExpiredChallengeError("Challenge is no longer valid")
+        if challenge.status == MfaChallengeStatus.APPROVED:
+            # Challenge has already been approved
+            return challenge.status
         if challenge.status != MfaChallengeStatus.PENDING:
             raise InvalidChallengeStateError(f"Challenge is in invalid state: {challenge.status}")