Fixing drill down pane not closing issue (#3761)

Netflix · Sep 7, 2023 · 84a9cc2 · 84a9cc2
1 parent 3c9df27
commit 84a9cc2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/dispatch/static/dispatch/src/dashboard/incident/IncidentOverview.vue b/src/dispatch/static/dispatch/src/dashboard/incident/IncidentOverview.vue
@@ -1,6 +1,6 @@
 <template>
   <v-container fluid grid-list-xl>
-    <incidents-drill-down-sheet v-model="showDrillDown" :items="detailItems" />
+    <incidents-drill-down-sheet v-if="showDrillDown" :items="detailItems" @close="closeDrillDown" />
     <v-layout row wrap>
       <v-flex class="d-flex justify-start" lg6 sm6 xs12>
         <v-btn color="info" @click="copyView"> Share View </v-btn>
@@ -211,6 +211,9 @@ export default {
         }
       )
     },
+    closeDrillDown() {
+      this.showDrillDown = false
+    },
   },
 
   computed: {

diff --git a/src/dispatch/static/dispatch/src/dashboard/incident/IncidentsDrillDownSheet.vue b/src/dispatch/static/dispatch/src/dashboard/incident/IncidentsDrillDownSheet.vue
@@ -31,7 +31,7 @@ export default {
 
   methods: {
     hideSheet() {
-      this.$emit("input", false)
+      this.$emit("close", false)
     },
   },