Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(models): reducing information for duplicates or associated incidents and cases #5619

Merged
merged 5 commits into from
Dec 14, 2024

Conversation

whitdog47
Copy link
Contributor

This PR implements changes to the Incident and Case models to restrict the display of full information for duplicate and associated cases and incidents. By introducing basic read models, we aim to ensure that restricted information is not exposed unnecessarily.

Models Updated:

  • Introduced CaseReadBasic and IncidentReadBasic models to provide a simplified view of cases and incidents, omitting potentially restricted details.
  • Updated references from CaseReadMinimal and IncidentReadMinimal to their respective basic models in various classes, including CaseRead, CaseUpdate, IncidentRead, and IncidentUpdate.
  • Adjusted the FeedbackBase and TaskBase models to utilize IncidentReadBasic for incident references.

@whitdog47 whitdog47 added bug Something isn't working security labels Dec 13, 2024
@whitdog47 whitdog47 self-assigned this Dec 13, 2024
@whitdog47 whitdog47 merged commit e3ee407 into master Dec 14, 2024
8 checks passed
@whitdog47 whitdog47 deleted the bugfix/dont-return-restricted branch December 14, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants