fix(conversation): fixing bookmarks without resource.name #5793
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the
add_conversation_bookmark
function where bookmarks could not be added if theresource
object lacked aname
attribute. The changes ensure that a bookmark can still be created by using alternative identifiers whenresource.name
is unavailable.Changes Made
resource_name
whenresource.name
is not present. It now checks forresource.resource_type
and usesdeslug_and_capitalize_resource_type
to generate a name. If neither is available, it defaults to the providedtitle
or "untitled resource".resource_name
instead of directly accessingresource.name
, ensuring consistent and meaningful logging even whenresource.name
is absent.resource_name
logic.