feat: icicle layout #64
Merged
+36
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiermar
suggested changes
Dec 11, 2018
|
@spiermar I included the proposed changes. Could you review? |
|
@bahtiyarkaba will do |
spiermar
approved these changes
Dec 18, 2018
|
The d3 transition is really nice. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve #8 by adding a dropdown to select the layout of the flame-graph, with "flame" or "icicle" options.
The icicle layout is drawn by setting inverted on the flame graph.
Dropdown is chosen as it will also be useful for/in case sunburst layout #45 would be incorporated as well. I plainly put the control next to reset button. We might need some cosmetic tweaking if it looks ugly.
The chosen layout is stored to localstorage for persistence.