[cards] support writing metadata #2452
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
valayDave
commented
Jun 13, 2025
valayDave
commented
- cards can now have metadata about important information created for them like ids/types/ other info in decorators
- This also allows us for book-keeping the attempts as cards are created.
- We write the metadata in the cli so we put something stateful on top to ensure we don't end up writing the metadata multiple times.
- Overall, since cards are being written async, we can only ensure best effort registration from metaflow side since we don't necessarily block when we save cards.
- This commit implementation will save metadata on a per-card basis. Instead of updating all card metadata at once. We do this because we will otherwise have multiple copies of the metadata in the database.
- The metadata writing is optional and can be disabled via the config variable.
- This addition also allows us to update the metaflow-service code for filtering cards based on attempt basis.
- Allow ensuring that cards can now have metadata about important information created for them like ids/types/ other info in decorators - This also allows us for book-keeping the attempts as cards are created. - We write the metadata in the cli so we need to put something stateful on top to enure we end up writing the metadata. - Overall, since cards are being written async, we can only ensure best effort registration of metaflow. We dont necessarily block when we save cards. - This commit implementation will save metadata on a per-card basis. Instead of updating all card metadata at once.
valayDave
force-pushed
the
valay-oss/cards-with-metadata
branch
from
fc141fc to
ee0c106
Compare
savingoyal
reviewed
Jun 13, 2025
| @@ -218,6 +218,8 @@ | |||
|
|
|||
| RUNTIME_CARD_RENDER_INTERVAL = from_conf("RUNTIME_CARD_RENDER_INTERVAL", 60) | |||
|
|
|||
| CARD_WRITE_TO_METADATA = from_conf("CARD_WRITE_TO_METADATA", True) | |||
There was a problem hiding this comment.
do we need to offer it as a top level config? we can start writing metadata always in the context of flows.
There was a problem hiding this comment.
@tuulos recommended that we keep the writing optional since it was not there earlier. Personally don't have a problem with removing it since the UI service might still use the same logic that retrieves stuff from the datastore.
There was a problem hiding this comment.
We discussed this in the weekly chat that it would be easy to keep things simple and consistent going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.