Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the
neurobench/benchmarks/benchmark.py
file, primarily focusing on enhancing the user interface and improving the benchmark's output presentation. The changes include the addition of therich
library for better console output, the removal oftqdm
for progress tracking, and the introduction of a custom progress bar and detailed result display.Key changes include:
User Interface Enhancements:
rich
library for improved console output and progress tracking. (pyproject.toml
,neurobench/benchmarks/benchmark.py
) [1] [2]rich.progress
to replacetqdm
for more detailed and visually appealing progress updates. (neurobench/benchmarks/benchmark.py
)rich.table
andrich.panel
to present benchmark results in a structured and readable format. (neurobench/benchmarks/benchmark.py
)Code Simplification and Cleanup:
mkdir
andtqdm
. (neurobench/benchmarks/benchmark.py
)to_nir
method by conditionally importingexport_to_nir
based on thesnntorch
version. (neurobench/benchmarks/benchmark.py
)These changes collectively improve the usability and readability of the benchmark output, making it easier for users to track progress and understand results.