Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mrtrix3src (latest version) to the apps list. #300

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

timrosenow
Copy link
Contributor

Added the mrtrix3src command to apps.json, as per NeuroDesk/neurocontainers#721

Copy link
Contributor

@stebo85 stebo85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax is not correct. I needs the version after the name and the comma needs to be moved.

instead of:

           "mrtrix3src": {
               "version": "latest",
               "exec": ""
           },

it needs to be:

            },
            "mrtrix3src latest": {
                "version": "latest",
                "exec": ""
            }

@timrosenow
Copy link
Contributor Author

My apologies, I have fixed those typos.

@timrosenow timrosenow requested a review from stebo85 August 13, 2024 06:08
@stebo85
Copy link
Contributor

stebo85 commented Aug 13, 2024

wonderful - that should work :)

@timrosenow
Copy link
Contributor Author

timrosenow commented Aug 13, 2024 via email

@stebo85 stebo85 merged commit b87b900 into NeuroDesk:main Aug 13, 2024
2 checks passed
@stebo85
Copy link
Contributor

stebo85 commented Aug 13, 2024

Thank you! I know we need to make this process easier and we are working on it! I hope we have updates on this soon :)

@timrosenow
Copy link
Contributor Author

timrosenow commented Aug 13, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants