Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ImageSeries/data required #481

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Make ImageSeries/data required #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/nwb.image.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@ groups:
- null
- null
- null
doc: Binary data representing images across frames.
quantity: '?'
doc: Binary data representing images across frames. If data are stored in an external
file, this should be an empty 3D array.
- name: dimension
dtype: int32
dims:
Expand Down
4 changes: 4 additions & 0 deletions docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Release Notes
- Fix incorrect dtype for electrodes table column "filtering" (float -> text)
- Remove "quantity: *" from the type definitions of ``OptogeneticStimulusSite`` and ``ImagingPlane``.
This change improves clarity of the schema to follow best practices. It has no functional effect on the schema.
- Require the "data" dataset in ``ImageSeries``. Since ``ImageSeries`` is a ``TimeSeries`` and ``TimeSeries`` requires
the "data" dataset, ``ImageSeries`` should also require the "data" dataset. Otherwise this creates problems for
inheritance and validation. If ``ImageSeries`` data are stored in an external file, then "data" should be set to
an empty 3D array.

2.3.0 (May 12, 2021)
---------------------
Expand Down