Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fcm 푸시 알림 스케줄러에 등록 #89
feat: fcm 푸시 알림 스케줄러에 등록 #89
Changes from 10 commits
5098e07
5ad4752
2a8bc24
608dfc6
4e9da91
4d7329e
591a7d7
b1a4c21
25055d1
a0ebd15
20387f6
b22174e
505f338
0f80d76
63e8bcf
aa908df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
미션 인증 2번 가능한 문제 해결하려고 lock 걸었습니다..!
커넥션이 여러 개라서 2개 이상의 커넥션이 같은 상태의
missionMember
레코드를 읽는 게 원인인 것 같습니다 (그래서 유효성 검사를 해도 insert가 되는,,,)더 나은 방법이나 오류 사항이 있으면 편하게 말씀해주세요 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우리 Redis 쓰고 있으니까 레디스 락 걸어보는 것도 괜찮을 것 같앙
추후에 계속해서 사용될 수 있는 쿼리 같아서 DB 락 보다는 필요한 곳에 레디스 락 거는게 조금 더 가볍지 않을까 생각하는데 지금 당장 중요한 부분은 아니라 백로그로 남겨도 좋을 것 같아!