Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Time Sync changes to WUTS #24

Merged
merged 23 commits into from
Sep 14, 2024

Conversation

dkosmari
Copy link
Collaborator

Summary of changes:

  • Use libwupsxx as an external submodule; code as been updated for the current libwupsxx, as some of the wups::config::item API changed.
  • Sources have a full copyright notice (year and author).
  • New option: synchronize when closing config (if changes were made). Closing the menu does not synchronize the clock unless this option is enabled (and any config was changed).
  • "Syncing Enabled" option was renamed to "Synchronize On Boot". Old config option will be migrated to the new one (sync -> sync_on_boot).
  • There's now an option to explicitly run the synchronization task inside the config menu.
  • Synchronization thread can now be safely canceled.
  • timezone_* classes and files were renamed to time_zone_*.
  • Plugin description, license and authors were removed from the Makefile. They're only used in main.cpp, there's no point in creating global macros for them.

I left the README unchanged, as you'll probably want to adjust names, phrasing, etc.

Daniel K. O. (dkosmari) added 23 commits October 6, 2023 22:38
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
--HG--
branch : upstream
@Nightkingale
Copy link
Owner

This all looks good to me! Thank you, as per usual!

@Nightkingale Nightkingale merged commit 52ee4d7 into Nightkingale:master Sep 14, 2024
1 check passed
@Nightkingale Nightkingale added the enhancement New feature or request label Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants