v0.4.0 #20
Merged
v0.4.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbowling
added
help wanted
t8rsalad
approved these changes
Jul 15, 2024
|
Everything here looks good. This is probably the direction we need to go anyway, but I'm curious what we'll have to do in Kraken to make it work. Will it just drop in, or will we have to completely uncurry the |
Seemingly no changes are required from Kraken to use the updated library. I pulled in this branch and fixed a build issue with older versions of ReScript not knowing what |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version attempts to this package with align ReScripts v11 uncurrying standards. It required us to explicitly type our parameters and uncurry our return value definitions.
If this PR passes review, I would prefer us to go this route over the
"uncurried": falseconfigured PR as this will be enforced behavior in Rescript 12.Both PRs update the
package.jsondependencies and remove"@glennsl/bs-jest"as it was abandoned and had numerous security advisories