Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rescript core #22

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Rescript core #22

merged 5 commits into from
Oct 17, 2024

Conversation

cbowling
Copy link

Imports @rescript/core and refactors the relevant code.

@cbowling cbowling added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 15, 2024
@cbowling cbowling self-assigned this Jul 15, 2024
jterry136
jterry136 approved these changes Jul 15, 2024
View reviewed changes
Copy link

@jterry136 jterry136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it turned out to be more manageable than I was expecting. LGTM

@cbowling
Copy link
Author

Tested and functional on Kraken by building with "@ninefx/bs-xml": "NineFX/bs-xml#rescript_core",

@cbowling cbowling merged commit fc08a63 into master Oct 17, 2024
2 checks passed
@cbowling cbowling deleted the rescript_core branch October 17, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jterry136 jterry136 jterry136 approved these changes

@t8rsalad t8rsalad t8rsalad approved these changes

@varnerac varnerac Awaiting requested review from varnerac

Assignees

@cbowling cbowling

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbowling @t8rsalad @jterry136