Skip to content

Commit

Permalink
Merge pull request #7 from Niurmiguel/development
Browse files Browse the repository at this point in the history
[REF] upgrade dependencies
  • Loading branch information
Niurmiguel authored Jun 15, 2022
2 parents bc71dc8 + e15b4bf commit a82a4be
Show file tree
Hide file tree
Showing 10 changed files with 1,095 additions and 1,122 deletions.
2 changes: 1 addition & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
node_modules

# don't lint build output (make sure it's set to your correct build folder name)
lib
# lib

# don't lint nyc coverage output
coverage
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ module.exports = {
'@typescript-eslint/no-explicit-any': 'off',
'@typescript-eslint/no-use-before-define': 'off',
'@typescript-eslint/no-non-null-assertion': 'off',
"@typescript-eslint/no-empty-function": "off",
'@typescript-eslint/ban-types': ['error', {
'types': {
'Function': false,
Expand Down
16 changes: 8 additions & 8 deletions lib/client/common/enums/videoPosition.enum.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,27 +5,27 @@ export enum VideoPositionType {
/**
* The value returned if the actual value is not exposed by the requested API version.
*/
UNKNOWN = "UNKNOWN",
UNKNOWN = 'UNKNOWN',

/**
* This position targets all of the above video positions.
*/
ALL = "ALL",
ALL = 'ALL',

/**
* The position defined as showing before the video starts playing.
*/
PREROLL = "PREROLL",
PREROLL = 'PREROLL',

/**
* The position defined as showing within the middle of the playing video.
*/
MIDROLL = "MIDROLL",
MIDROLL = 'MIDROLL',

/**
* The position defined as showing after the video is completed.
*/
POSTROLL = "POSTROLL",
POSTROLL = 'POSTROLL',
}

/**
Expand All @@ -35,10 +35,10 @@ export enum VideoBumperType {
/**
* Represents the bumper position before the ad pod.
*/
BEFORE = "BEFORE",
BEFORE = 'BEFORE',

/**
* Represents the bumper position after the ad pod.
*/
AFTER = "AFTER",
}
AFTER = 'AFTER',
}
13 changes: 2 additions & 11 deletions lib/client/common/types/customCriteria.type.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@
import {
CmsMetadataCriteriaComparisonOperator,
ComparisonOperator,
LogicalOperator,
} from '../enums';
import { CmsMetadataCriteriaComparisonOperator, ComparisonOperator, LogicalOperator } from '../enums';

/**
* A CustomCriteria object is used to perform custom criteria targeting on custom targeting keys of type CustomTargetingKey.Type.PREDEFINED or CustomTargetingKey.Type.FREEFORM.
Expand Down Expand Up @@ -66,10 +62,5 @@ export type CustomCriteriaSet = {
/**
* The custom criteria. This attribute is required.
*/
children: (
| CustomCriteriaSet
| CustomCriteria
| CmsMetadataCriteria
| AudienceSegmentCriteria
)[];
children: (CustomCriteriaSet | CustomCriteria | CmsMetadataCriteria | AudienceSegmentCriteria)[];
};
7 changes: 1 addition & 6 deletions lib/client/common/types/grpSettings.type.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
import {
GrpProvider,
GrpTargetGender,
NielsenCtvPacingType,
PacingDeviceCategorizationType,
} from '../enums';
import { GrpProvider, GrpTargetGender, NielsenCtvPacingType, PacingDeviceCategorizationType } from '../enums';

/**
* GrpSettings contains information for a line item that will have a target demographic when serving.
Expand Down
9 changes: 2 additions & 7 deletions lib/client/services/forecast/forecast.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,14 @@ export class ForecastService implements ForecastServiceOperations {
return this._client.getDeliveryForecast({ lineItems, forecastOptions });
}

getDeliveryForecastByIds(
lineItemIds: number[],
forecastOptions: DeliveryForecastOptions,
): Promise<DeliveryForecast> {
getDeliveryForecastByIds(lineItemIds: number[], forecastOptions: DeliveryForecastOptions): Promise<DeliveryForecast> {
return this._client.getDeliveryForecastByIds({
lineItemIds,
forecastOptions,
});
}

getTrafficData(
trafficDataRequest: TrafficDataRequest,
): Promise<TrafficDataResponse> {
getTrafficData(trafficDataRequest: TrafficDataRequest): Promise<TrafficDataResponse> {
return this._client.getTrafficData({ trafficDataRequest });
}
}
9 changes: 2 additions & 7 deletions lib/client/services/forecast/forecastService.interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,7 @@ export interface ForecastServiceOperations {
* @param lineItemIds the IDs of line items to be forecasted for delivery
* @param forecastOptions options controlling the forecast
*/
getDeliveryForecastByIds(
lineItemIds: number[],
forecastOptions: DeliveryForecastOptions,
): Promise<DeliveryForecast>;
getDeliveryForecastByIds(lineItemIds: number[], forecastOptions: DeliveryForecastOptions): Promise<DeliveryForecast>;
/**
* Returns forecasted and historical traffic data for the segment of traffic specified by the provided request.
*
Expand All @@ -74,7 +71,5 @@ export interface ForecastServiceOperations {
* @param trafficDataRequest the request specifying the segment of traffic for which data should be returned
* @returns a dto containing forecasted and historical traffic data for the specified segment of traffic
*/
getTrafficData(
trafficDataRequest: TrafficDataRequest,
): Promise<TrafficDataResponse>;
getTrafficData(trafficDataRequest: TrafficDataRequest): Promise<TrafficDataResponse>;
}
9 changes: 1 addition & 8 deletions lib/common/types/statement.type.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,7 @@ export type String_ValueMapEntry = {
value: Value;
};

export type Value =
| string
| number
| object
| boolean
| DateTime
| Date
| Value[];
export type Value = string | number | object | boolean | DateTime | Date | Value[];

/**
* Captures a page of any objects.
Expand Down
Loading

0 comments on commit a82a4be

Please sign in to comment.