cabal2nix: use inNixShell auto-call argument over environment var #665
+13
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maralorn
approved these changes
Aug 28, 2025
|
Unless people have |
|
Really? I thought this autocalling only works when the function is the attribute passed to nix-shell. When however someone has a wrapper around their default.nix file, e.g. to pass in a pinned nixpkgs they would need to modify that wrapper to pass through that argument. don’t they? |
The set environment variable leaks relatively easily leading to unexpected behavior when, for example, running nix-build from a shell or direnv environment. Nix 2.4 has provided an alternative mechanism for this which doesn't exhibit this flaw. NixOS/nix#3168 NixOS/nixpkgs#436814 NixOS/nixpkgs#9438
sternenseemann
force-pushed
the
cabal2nix-auto-call-in-nix-shell
branch
from
7b6fddf to
f1f3641
Compare
|
That's true. I've clarified that in the changelog entry. I don't think it's a big deal because I don't believe anyone is doing that and automatically generating the expression via ifd (hopefully). |
maralorn
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The set environment variable leaks relatively easily leading to unexpected behavior when, for example, running nix-build from a shell or direnv environment. Nix 2.4 has provided an alternative mechanism for this which doesn't exhibit this flaw.
NixOS/nix#3168
NixOS/nixpkgs#436814
NixOS/nixpkgs#9438