Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in hydra-compress-logs #1450

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Fix race condition in hydra-compress-logs #1450

merged 1 commit into from
Mar 16, 2025

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 2, 2025

On hydra.nixos.org the following happened and this is the most plausible fix I could come up with.

Mar 02 01:45:00 mimas systemd[1]: Started hydra-compress-logs.service.
Mar 02 01:46:20 mimas hydra-compress-logs-start[2162537]: find: ‘/var/lib/hydra/build-logs/fv/qzi69s810vppw3ld5l04q9w7grlady-system-path.drv’: No such file or directory
Mar 02 01:46:33 mimas systemd[1]: hydra-compress-logs.service: Main process exited, code=exited, status=1/FAILURE
Mar 02 01:46:33 mimas systemd[1]: hydra-compress-logs.service: Failed with result 'exit-code'.

vcunat
vcunat approved these changes Mar 2, 2025
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, why not. I hope it will suffice to avoid common races.

@Ericson2314 Ericson2314 merged commit d2db3c7 into master Mar 16, 2025
2 checks passed
@mweinelt mweinelt deleted the hydra-compress-race branch March 16, 2025 18:38
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this pull request Mar 17, 2025
@SuperSandro2000
nixos/nixos: fix race condition in hydra-compress-logs
6a45c7c 
Source NixOS/hydra#1450
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this pull request Mar 17, 2025
@SuperSandro2000
nixos/nixos: fix race condition in hydra-compress-logs
325aae1 
Source NixOS/hydra#1450
@SuperSandro2000 SuperSandro2000 mentioned this pull request Mar 17, 2025
Merged
13 tasks
@SuperSandro2000
Copy link
Member

NixOS/nixpkgs#390685

SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this pull request Mar 17, 2025
@SuperSandro2000
nixos/nixos: fix race condition in hydra-compress-logs
5be629a 
Source NixOS/hydra#1450
SuperSandro2000 added a commit to SuperSandro2000/nixpkgs that referenced this pull request Mar 17, 2025
@SuperSandro2000
nixos/hydra: fix race condition in hydra-compress-logs
588f41b 
Source NixOS/hydra#1450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mweinelt @SuperSandro2000 @vcunat @Ericson2314