Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow umbriel to send emails as nixos.org #566

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Feb 23, 2025

Depends on #571. Please review/merge that PR first.

Once this change is deployed, we should be able to start sending test emails from @nixos.org email addresses using umbriel. I updated our SPF record in a way such that it should allow umbriel without breaking our existing email sending capabilities (ImprovMX and gandi.net).

This does not change our MX (yet): ImprovMX will still be receiving emails send to nixos.org. To verify that we can receive emails sent to nixos.org addresses, I plan to edit /etc/hosts on my personal mailserver and send some test emails. Do folks have better ideas for testing this out?

@jfly jfly requested a review from Mic92 February 23, 2025 01:36
@jfly jfly requested a review from a team as a code owner February 23, 2025 01:36
@jfly jfly force-pushed the issue-485-sending-as-nixos.org branch from 670dfe6 to 261a17f Compare February 23, 2025 01:39
@jfly jfly force-pushed the issue-485-sending-as-nixos.org branch 2 times, most recently from 24bc5d9 to 4fe3460 Compare February 25, 2025 12:01
@jfly jfly force-pushed the issue-485-sending-as-nixos.org branch from 4fe3460 to ec013aa Compare March 8, 2025 18:02
@jfly jfly force-pushed the issue-485-sending-as-nixos.org branch from ec013aa to 0a71493 Compare March 11, 2025 08:29
Once this change is deployed, we should be able to start sending test
emails from `@nixos.org` email addresses using `umbriel`. I updated our
SPF record in a way such that it should allow `umbriel` without breaking
our existing email sending capabilities with ImprovMX.

This does *not* change our MX (yet): ImprovMX will still be receiving
emails send to `nixos.org`. To verify that we can receive emails sent to
`nixos.org` addresses, I plan to edit `/etc/hosts` on my personal
mailserver and send some test emails. Do folks have better ideas for
testing this out?
@jfly jfly force-pushed the issue-485-sending-as-nixos.org branch from b4c3c1b to 0b768b8 Compare March 11, 2025 08:36
@jfly
Copy link
Contributor Author

jfly commented Mar 11, 2025

@Mic92, sorry I force pushed locally (without using --force-with-lease 🙈) and I stomped on your commit!

@Mic92
Copy link
Member

Mic92 commented Mar 11, 2025

@Mic92, sorry I force pushed locally (without using --force-with-lease 🙈) and I stomped on your commit!

Just amend the fix to your existing commit.

@jfly
Copy link
Contributor Author

jfly commented Mar 11, 2025

Just amend the fix to your existing commit.

Yes, already done. I assume you and I did the same thing, but I can't figure out how to get github to show me what you did.

@mweinelt mweinelt merged commit e20f218 into NixOS:main Mar 11, 2025
13 checks passed
@mweinelt
Copy link
Member

DNS changes applied.

@jfly jfly deleted the issue-485-sending-as-nixos.org branch March 11, 2025 15:07
@jfly
Copy link
Contributor Author

jfly commented Mar 11, 2025

Thanks @mweinelt! Any idea why we seem to have 2 TXT records for mail._domainkey.nixos.org?

$ nslookup -type=TXT mail._domainkey.nixos.org
;; Truncated, retrying in TCP mode.
Server:		127.0.0.53
Address:	127.0.0.53#53

Non-authoritative answer:
mail._domainkey.nixos.org	text = "v=DKIM1; p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDcgNq4+Y23GxN8Mdza437tL5DuJJZU1y6VzTCwSi6cBNLyBDci2cmqXx/gm1sA3yv7+h+8/OyJpEgcbCIW/Ygs1XLuECqvXVX8MU6Djn4KY+d2sU1tlUdqvNM86puoneQtjEv9rDsjf3HGqaeOcjetFnQW7H+qcNcaEShxyKztzQIDAQAB"
mail._domainkey.nixos.org	text = "k=rsa;p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDeMVIzrCa3T14JsNY0IRv5/2V1/v2itlviLQBwXsa7shBD6TrBkswsFUToPyMRWC9tbR/5ey0nRBH0ZVxp+lsmTxid2Y2z+FApQ6ra2VsXfbJP3HE6wAO0YTVEJt1TmeczhEd2Jiz/fcabIISgXEdSpTYJhb0ct0VJRxcg4c8c7wIDAQAB"

The first one is expected from this PR. I'm not sure if the second one existed before this PR, but I can't find any evidence of it in our git repo.

@vcunat
Copy link
Member

vcunat commented Mar 15, 2025

Now I see this DNS record exactly in sync with the current state after 20db5e89e085db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants