Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert if scraping jobs fail #590

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Alert if scraping jobs fail #590

merged 1 commit into from
Mar 19, 2025

Conversation

jfly
Copy link
Contributor

@jfly jfly commented Mar 13, 2025

In addition to alerting on failing scraping jobs, we need to address our existing failures, which I researched in
#551. Copy pasting analysis from there:

  • r13y: Last successful scrape: 2024-09-21. Website is down. @grahamc didn't respond to my query.
  • rfc39: IMO, this is mis-architected. This scrapes a job that only runs periodically, which means we regularly get scrape failures. I've filed Recommendations for integrating with Prometheus? rfc39#14 with the upstream project seeking advice.
    • Since we don't actually alert on these metrics, I propose doing the simplest thing and just disabling this scrape job for now.
  • hydra_notify: Last successful scrape: 2024-08-02. We disabled this service in 2024, there's no reason to keep scraping it.

(fixes #551)

@jfly jfly requested a review from a team as a code owner March 13, 2025 20:05
In addition to alerting on failing scraping jobs, we need to address our
existing failures, which I researched in
NixOS#551. Copy pasting analysis from
there:

- `r13y`: Last successful scrape: 2024-09-21. Website is down. @grahamc
  didn't respond to my query.
- `rfc39`: IMO, this is mis-architected. This scrapes a job that only
  runs periodically, which means we regularly get scrape failures. I've
  filed NixOS/rfc39#14 with the upstream
  project seeking advice.
  - Since we don't actually alert on these metrics, I propose doing the
    simplest thing and just disabling this scrape job for now.
- `hydra_notify`: Last successful scrape: 2024-08-02. We disabled this
  service [in
  2024](NixOS@66da5cf),
  there's no reason to keep scraping it.
@Mic92 Mic92 enabled auto-merge March 19, 2025 14:05
@Mic92 Mic92 merged commit 91ca573 into NixOS:main Mar 19, 2025
13 checks passed
@Mic92
Copy link
Member

Mic92 commented Mar 19, 2025

applied

@jfly jfly deleted the issue-551 branch March 19, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address prometheus scraping jobs that are failing
2 participants