libfetchers-tests: Add back git-utils.cc #12511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xokdvium I think it would be better to fix this. In the old build system, we didn't need to reference all the build files. The Meson rewrite was done over the better part of a year, so it was sadly easy to forget files. |
Ericson2314
requested changes
Feb 18, 2025
Seems like this got dropped at some point during meson migration, so put it back in the build system. Drop all tests for `parseGitUrl`, since that function doesn't exist and migrating doesn't look sensible because git-lfs stuff seems to use `ParsedURL`.
xokdvium
force-pushed
the
chore/delete-dead-code
branch
from
db643c5 to
d95b7fe
Compare
xokdvium
changed the title
|
Yeah I guess so |
edolstra
approved these changes
Feb 20, 2025
Ericson2314
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Seems like this got dropped at some point during meson migration, so
put it back in the build system.
Drop all tests for
parseGitUrl, since that function doesn't existand migrating doesn't look sensible because git-lfs stuff seems to use
ParsedURL.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.