-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libjwt-typed: unbreak with minor changes #185477
libjwt-typed: unbreak with minor changes #185477
Conversation
Thx! 2 small things. a) you need to move the libjwt dependency from the hackage-packages.nix (which is autogenerated and will be overriden) to configuration-nix.nix. See the miniball override in that file as an example for how to do that. |
@maralorn thank you for your encouragement on Mastodon and Matrix. Your nice help has made this relatively painless. Here is the issue you requested I make, in order to alert the author of |
Nearly there. Can you put the link into a comment above the line with the override? I personally also like to add a timestamp
and then please rebase everything into one commit. |
Okay, it's all in one commit now, plus there's also the timestamped comment you requested, @maralorn. |
Sorry to bother you again, but that comment belongs together with the jailbreak in the configuration-common.nix. After all it’s about why you do the jailbreak. The library override already had a satisfying comment. |
Unbreak libjwt-typed. Succesfully built using: env NIXPKGS_ALLOW_BROKEN=1 nix-build --no-out-link -A haskellPackages.libjwt-typed This was accomplished by removing dependency bounds, skipping tests, and adding the libjwt librarySystemDepends. Removed `broken` status from libjwt-typed. I have not tested using what was built in the nix-build command above in a local project.
That makes sense, sorry about that, @maralorn. I have made the amended commit changing the comments. Thank you. |
Thank, you! Next time you can also run |
Unbreak libjwt-typed. I was able to build using:
nix-build --no-out-link -A haskellPackages.libjwt-typed .
This was accomplished by removing dependency
bounds, skipping tests, and adding the libjwt
librarySystemDepends.
Removed
broken
status from libjwt-typed.This has not been tested in any concrete way (I am
essentially new to Nix). I would have liked to try
using these changes with a project which spurred
these changes, but I am unsure how to override in
a manner that used the local nixpkgs repo (where I
worked on these changes).
Description of changes
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes