Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjwt-typed: unbreak with minor changes #185477

Merged
merged 1 commit into from
Aug 8, 2022
Merged

libjwt-typed: unbreak with minor changes #185477

merged 1 commit into from
Aug 8, 2022

Conversation

someodd
Copy link
Contributor

@someodd someodd commented Aug 6, 2022

Unbreak libjwt-typed. I was able to build using:

nix-build --no-out-link -A haskellPackages.libjwt-typed .

This was accomplished by removing dependency
bounds, skipping tests, and adding the libjwt
librarySystemDepends.

Removed broken status from libjwt-typed.

This has not been tested in any concrete way (I am
essentially new to Nix). I would have liked to try
using these changes with a project which spurred
these changes, but I am unsure how to override in
a manner that used the local nixpkgs repo (where I
worked on these changes).

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 6, 2022
@maralorn
Copy link
Member

maralorn commented Aug 7, 2022

Thx!

2 small things.

a) you need to move the libjwt dependency from the hackage-packages.nix (which is autogenerated and will be overriden) to configuration-nix.nix. See the miniball override in that file as an example for how to do that.
b) Can you open an issue upstream informing them which bounds are out of date and put that in a comment?

@someodd
Copy link
Contributor Author

someodd commented Aug 7, 2022

@maralorn thank you for your encouragement on Mastodon and Matrix. Your nice help has made this relatively painless.

Here is the issue you requested I make, in order to alert the author of libjwt-typed that the version bounds are out-of-date for said project: marcin-rzeznicki/libjwt-typed#2

@maralorn
Copy link
Member

maralorn commented Aug 7, 2022

Nearly there. Can you put the link into a comment above the line with the override? I personally also like to add a timestamp

# 2022-08-07: Bounds are to restrictive: https://github.com/marcin-rzeznicki/libjwt-typed/issues/2

and then please rebase everything into one commit.

@someodd
Copy link
Contributor Author

someodd commented Aug 8, 2022

Okay, it's all in one commit now, plus there's also the timestamped comment you requested, @maralorn.

@maralorn
Copy link
Member

maralorn commented Aug 8, 2022

Sorry to bother you again, but that comment belongs together with the jailbreak in the configuration-common.nix. After all it’s about why you do the jailbreak. The library override already had a satisfying comment.

Unbreak libjwt-typed. Succesfully built using:

  env NIXPKGS_ALLOW_BROKEN=1 nix-build --no-out-link -A haskellPackages.libjwt-typed

This was accomplished by removing dependency
bounds, skipping tests, and adding the libjwt
librarySystemDepends.

Removed `broken` status from libjwt-typed.

I have not tested using what was built in the
nix-build command above in a local project.
@someodd
Copy link
Contributor Author

someodd commented Aug 8, 2022

That makes sense, sorry about that, @maralorn. I have made the amended commit changing the comments. Thank you.

@maralorn
Copy link
Member

maralorn commented Aug 8, 2022

Thank, you!

Next time you can also run maintainers/scripts/haskell/regenerate-hackage-packages.sh to remove the broken flag from the hackage-packages.nix file, but we will run it later on the branch this time …

@maralorn maralorn merged commit 6be915f into NixOS:haskell-updates Aug 8, 2022
@someodd someodd deleted the fix/libjwt-typed-unbroken branch August 9, 2022 04:43
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants