Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neothesia: init at unstable-2024-07-21 #256882

Closed
wants to merge 1 commit into from

Conversation

auroraanna
Copy link
Contributor

Description of changes

Added neothesia package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@auroraanna
Copy link
Contributor Author

Blocked by PolyMeilex/Neothesia#77.

@auroraanna auroraanna self-assigned this Sep 23, 2023
@auroraanna auroraanna added the 2.status: work-in-progress This PR isn't done label Sep 23, 2023
@auroraanna auroraanna force-pushed the neothesia branch 4 times, most recently from 5a57cb5 to c848262 Compare September 24, 2023 21:00
@auroraanna auroraanna added the 8.has: package (new) This PR adds a new package label Sep 24, 2023
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good! The out/video.mp4 file needs to be removed and I left a few more comments

Also regarding PolyMeilex/Neothesia#77 (comment), it looks like cosmic-text has since made a release

Thank you for this!

pkgs/applications/audio/neothesia/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/neothesia/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/neothesia/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/neothesia/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/neothesia/default.nix Outdated Show resolved Hide resolved
strictDeps = true;
nativeBuildInputs = [
pkg-config
cmake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is cmake actually doing here? I can't tell that it gets used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I don't remember anymore why I put it there but I didn't get any errors when building without it so I guess it's not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not getting any errors without atkmm anymore either. pretty sure it was needed at some point.

pkgs/applications/audio/neothesia/default.nix Outdated Show resolved Hide resolved
@auroraanna
Copy link
Contributor Author

Hmm, on my latest build, Neothesia crashes.

thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /build/cargo-vendor-dir/wgpu-hal-0.17.1/src/gles/egl.rs:813:77
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: queue 0x55df0e934650 destroyed while proxies still attached:
  xdg_wm_base@21 still attached
  wl_output@15 still attached
  wl_output@14 still attached
  wl_seat@13 still attached
  xdg_activation_v1@12 still attached
  wp_viewporter@11 still attached
  zwp_text_input_manager_v3@10 still attached
  zwp_pointer_constraints_v1@9 still attached
  zwp_relative_pointer_manager_v1@8 still attached
  zxdg_decoration_manager_v1@7 still attached
  wl_subcompositor@6 still attached
  wl_compositor@5 still attached
  wl_shm@4 still attached
  wl_registry@2 still attached

]);

cargoLock = {
lockFile = "${src}/Cargo.lock";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lockFile = "${src}/Cargo.lock";
lockFile = ./Cargo.lock;

This is IFD here (https://nixos.org/manual/nix/unstable/language/import-from-derivation) and that is currently disallowed in nixpkgs

You'll need to copy the Cargo.lock file into nixpkgs unfortunately and reference it

(also the out dir in the root still needs to be removed: https://github.com/NixOS/nixpkgs/pull/256882/files#diff-ebf70d31835017636a8cab71dd0e0d2f3b397b9a331a98eabf030ccd60f8c0ba)

@lilyinstarlight
Copy link
Member

Hmm, on my latest build, Neothesia crashes.

Hmmm, I'll try to investigate at some point myself too, because that does seem weird

@auroraanna auroraanna closed this Nov 14, 2023
@auroraanna auroraanna reopened this Nov 14, 2023
@auroraanna
Copy link
Contributor Author

auroraanna commented Nov 14, 2023

Also regarding PolyMeilex/Neothesia#77 (comment), it looks like cosmic-text has since made a release

the cosmic-text dependency hasn't been updated to 0.10.0 though

$ cargo tree --depth 1000 | nl | rg cosmic
   133	│   ├── cosmic-text v0.9.0
   276	│   │   ├── cosmic-text v0.9.0 (*)
   385	│   │   │   ├── cosmic-text v0.9.0 (*)

@auroraanna
Copy link
Contributor Author

So, neothesia has the new cosmic-text version now but it still crashes for me. Even tried it on Xorg and found that libxkbcommon was missing there so I added that.

@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 1, 2024
@auroraanna auroraanna changed the title neothesia: init at unstable-2023-09-23 neothesia: init at unstable-2024-07-21 Aug 1, 2024
@auroraanna
Copy link
Contributor Author

oops, i forgot someone already added neothesia under by-name and thought i did that

@auroraanna auroraanna closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: work-in-progress This PR isn't done 8.has: package (new) This PR adds a new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants