-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
neothesia: init at unstable-2024-07-21 #256882
Conversation
Blocked by PolyMeilex/Neothesia#77. |
1928d03
to
c384030
Compare
5a57cb5
to
c848262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks pretty good! The out/video.mp4
file needs to be removed and I left a few more comments
Also regarding PolyMeilex/Neothesia#77 (comment), it looks like cosmic-text has since made a release
Thank you for this!
strictDeps = true; | ||
nativeBuildInputs = [ | ||
pkg-config | ||
cmake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is cmake actually doing here? I can't tell that it gets used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, I don't remember anymore why I put it there but I didn't get any errors when building without it so I guess it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not getting any errors without atkmm anymore either. pretty sure it was needed at some point.
ea32b83
to
9cb6a40
Compare
Hmm, on my latest build, Neothesia crashes. thread 'main' panicked at 'called `Option::unwrap()` on a `None` value', /build/cargo-vendor-dir/wgpu-hal-0.17.1/src/gles/egl.rs:813:77
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: queue 0x55df0e934650 destroyed while proxies still attached:
xdg_wm_base@21 still attached
wl_output@15 still attached
wl_output@14 still attached
wl_seat@13 still attached
xdg_activation_v1@12 still attached
wp_viewporter@11 still attached
zwp_text_input_manager_v3@10 still attached
zwp_pointer_constraints_v1@9 still attached
zwp_relative_pointer_manager_v1@8 still attached
zxdg_decoration_manager_v1@7 still attached
wl_subcompositor@6 still attached
wl_compositor@5 still attached
wl_shm@4 still attached
wl_registry@2 still attached |
9cb6a40
to
fb5d30e
Compare
]); | ||
|
||
cargoLock = { | ||
lockFile = "${src}/Cargo.lock"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lockFile = "${src}/Cargo.lock"; | |
lockFile = ./Cargo.lock; |
This is IFD here (https://nixos.org/manual/nix/unstable/language/import-from-derivation) and that is currently disallowed in nixpkgs
You'll need to copy the Cargo.lock file into nixpkgs unfortunately and reference it
(also the out
dir in the root still needs to be removed: https://github.com/NixOS/nixpkgs/pull/256882/files#diff-ebf70d31835017636a8cab71dd0e0d2f3b397b9a331a98eabf030ccd60f8c0ba)
Hmmm, I'll try to investigate at some point myself too, because that does seem weird |
the cosmic-text dependency hasn't been updated to 0.10.0 though $ cargo tree --depth 1000 | nl | rg cosmic
133 │ ├── cosmic-text v0.9.0
276 │ │ ├── cosmic-text v0.9.0 (*)
385 │ │ │ ├── cosmic-text v0.9.0 (*) |
fb5d30e
to
a4a6b9b
Compare
a4a6b9b
to
5d01291
Compare
So, neothesia has the new cosmic-text version now but it still crashes for me. Even tried it on Xorg and found that libxkbcommon was missing there so I added that. |
Co-authored-by: Lily Foster <[email protected]>
oops, i forgot someone already added neothesia under by-name and thought i did that |
Description of changes
Added neothesia package.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)