Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.raincloudy: disable on Python 3.12 #312637

Merged
merged 3 commits into from
May 18, 2024
Merged

python312Packages.raincloudy: disable on Python 3.12 #312637

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
595501a
python311Packages.raincloudy: refactor
fabaff May 18, 2024
cefc7f0
python312Packages.raincloudy: format with nixfmt
fabaff May 18, 2024
254e223
python312Packages.raincloudy: disable on Python 3.12
fabaff May 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 31 additions & 27 deletions pkgs/development/python-modules/raincloudy/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,51 +1,54 @@
{ lib
, aiohttp
, aioresponses
, beautifulsoup4
, buildPythonPackage
, fetchFromGitHub
, html5lib
, pytest-asyncio
, pytest-aiohttp
, pytestCheckHook
, pythonOlder
, requests
, requests-mock
, setuptools
, setuptools-scm
, urllib3
{
lib,
aiohttp,
aioresponses,
beautifulsoup4,
buildPythonPackage,
fetchFromGitHub,
html5lib,
pytest-asyncio,
pytest-aiohttp,
pytestCheckHook,
pythonAtLeast,
pythonOlder,
requests,
requests-mock,
setuptools,
setuptools-scm,
urllib3,
}:

buildPythonPackage rec {
pname = "raincloudy";
version = "1.2.0";
format = "setuptools";
pypriject = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?


disabled = pythonOlder "3.7";
# https://github.com/vanstinator/raincloudy/issues/65
disabled = pythonOlder "3.7" || pythonAtLeast "3.12";

src = fetchFromGitHub {
owner = "vanstinator";
repo = pname;
repo = "raincloudy";
rev = "refs/tags/${version}";
hash = "sha256-qCkBVirM09iA1sXiOB9FJns8bHjQq7rRk8XbRWrtBDI=";
};

nativeBuildInputs = [
setuptools
setuptools-scm
];

postPatch = ''
# https://github.com/vanstinator/raincloudy/pull/60
substituteInPlace setup.py \
--replace "bs4" "beautifulsoup4" \
--replace-fail "bs4" "beautifulsoup4" \

# fix raincloudy.aio package discovery, by relying on
# autodiscovery instead.
sed -i '/packages=/d' setup.py
'';

propagatedBuildInputs = [
build-system = [
setuptools
setuptools-scm
];

dependencies = [
aiohttp
requests
beautifulsoup4
Expand Down Expand Up @@ -74,7 +77,8 @@ buildPythonPackage rec {
meta = with lib; {
description = "Module to interact with Melnor RainCloud Smart Garden Watering Irrigation Timer";
homepage = "https://github.com/vanstinator/raincloudy";
license = with licenses; [ asl20 ];
changelog = "https://github.com/vanstinator/raincloudy/releases/tag/${version}";
license = licenses.asl20;
maintainers = with maintainers; [ fab ];
};
}