-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib.systems: introduce toolchain, cc, and bintools attributes #365057
Open
RossComputerGuy
wants to merge
32
commits into
NixOS:master
Choose a base branch
from
RossComputerGuy:feat/toolchain-attrs
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
lib.systems: introduce toolchain, cc, and bintools attributes #365057
RossComputerGuy
wants to merge
32
commits into
NixOS:master
from
RossComputerGuy:feat/toolchain-attrs
+200
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
6.topic: rust
6.topic: windows
Running, or buiding, packages on Windows
6.topic: stdenv
Standard environment
6.topic: systemd
6.topic: lib
The Nixpkgs function library
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
labels
Dec 13, 2024
RossComputerGuy
force-pushed
the
feat/toolchain-attrs
branch
3 times, most recently
from
December 14, 2024 00:20
7a3eca0
to
2a005fa
Compare
RossComputerGuy
force-pushed
the
feat/toolchain-attrs
branch
2 times, most recently
from
December 14, 2024 00:41
9c8b44b
to
f6da63d
Compare
github-actions
bot
added
10.rebuild-darwin: 5001+
and removed
10.rebuild-darwin: 11-100
labels
Dec 14, 2024
The main idea and motivation is in: pkgs/stdenv/cross/default.nix |
RossComputerGuy
force-pushed
the
feat/toolchain-attrs
branch
from
December 14, 2024 00:51
f6da63d
to
ec79349
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
and removed
10.rebuild-darwin: 5001+
labels
Dec 14, 2024
RossComputerGuy
force-pushed
the
feat/toolchain-attrs
branch
2 times, most recently
from
December 14, 2024 01:33
10cd2ba
to
2b4d320
Compare
github-actions
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
Dec 14, 2024
github-actions
bot
added
10.rebuild-darwin: 5001+
and removed
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
labels
Jan 24, 2025
RossComputerGuy
force-pushed
the
feat/toolchain-attrs
branch
from
January 24, 2025 05:54
d0b0779
to
1384d84
Compare
github-actions
bot
added
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
and removed
10.rebuild-darwin: 5001+
labels
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: lib
The Nixpkgs function library
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
6.topic: python
6.topic: rust
6.topic: stdenv
Standard environment
6.topic: systemd
6.topic: windows
Running, or buiding, packages on Windows
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Replaces
useLLVM
,useArocc
, anduseZig
withtoolchain
,cc
,linker
, andbintools
attributes. This might not produce any rebuilds but we'll see. This has the advantage of preventingusing${compiler}
flags from colliding and not working correctly if we were to stack multiplepkgs*
together.nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.